Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💡 Disallow connection of wallet connected to different than GovTool network #1728

Open
MSzalowski opened this issue Aug 13, 2024 · 2 comments

Comments

@MSzalowski
Copy link
Contributor

MSzalowski commented Aug 13, 2024

Area

Wrapper

Is there new design needed?

Yes

What?

Disallow connecting wallet that connects to different than GovTool network.

Why?

As described in this comment in discussion.

How?

(Optional) User Story with acceptance criteria

As any user, I want to be informed that I am trying to connect to GovTool with the wallet connected to a different network.

@MSzalowski
Copy link
Contributor Author

MSzalowski commented Aug 13, 2024

@Ryun1 Do you think this issue makes sense? Having a wallet connected to other than GovTool network makes GovTool displaying wrong values, which without any warning might only bring the confusion.

That is also my candidate for the issue reported here

@Ryun1
Copy link
Member

Ryun1 commented Aug 13, 2024

The problem is that via the CIP-30 wallet connection
The DApp cannot differentiate between testnets via the api.getNetworkId()
This is a longstanding issue

I suppose one hack around this is;

  • compare the UTxOs reported by the wallet to UTxOs reported by GovTool backend?

Would have to be UTxOs as these are unique across networks, unlike credentials and addresses.

There might be an easier workaround, if you can think of one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

2 participants