Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Libre.fm support #41

Open
Phate6660 opened this issue May 23, 2021 · 6 comments
Open

Feature Request: Libre.fm support #41

Phate6660 opened this issue May 23, 2021 · 6 comments
Labels
enhancement New feature or request

Comments

@Phate6660
Copy link

Phate6660 commented May 23, 2021

This looks like a great project, and I would love to use it.
I use libre.fm however and it doesn't seem to be supported.

I'd be more than happy to try my hand at implementing it myself in a PR as well.
I'm just not sure how quickly I'll be able to get to it.
I'm pretty busy with IRL things as well as various projects.

As a side note: Once the feature gets implemented and I start using it
(I'll most likely end up using it daily), I will also be glad to create Gentoo ebuilds for this.

Edit: I'd also be happy to make an OpenRC service too.

@InputUsername
Copy link
Owner

Thank you for your interest in the project!

I'd be glad to help you out to create a PR for Libre.fm support.
Rescrobbled uses rustfm-scrobble for Last.fm scrobbling, and it seems there is an open issue to add Libre.fm support to it.

The issue has been open for a long time, perhaps you could help move it forward? Unfortunately I don't have time to do so myself at the moment.

As a side note: Once the feature gets implemented and I start using it
(I'll most likely end up using it daily), I will also be glad to create Gentoo ebuilds for this.

Edit: I'd also be happy to make an OpenRC service too.

Both would be very welcome!

@InputUsername InputUsername added the enhancement New feature or request label May 24, 2021
@InputUsername
Copy link
Owner

Not sure if you've had a look at rescrobbled code itself yet, but wanted to give a heads-up that I've added some changes on the development branch that should make it a bit easier to add support for Libre.fm.

@shymega
Copy link

shymega commented Jul 23, 2021

Hey, I saw you mentioned my issue on rustfm-scrobble. I had some data loss when I last worked on it - it even affected my college work, lost a fair few assignments! - but I still mean to add Libre.fm support. It's also necessary for my modular scrobbler (backed by SQLite, very similar to this one), so that was my reason for implementing Libre.fm support.

I also need to write a crate for Listenbrainz, which you may be interested in.

EDIT: Actually, it might even be better to add Listenbrainz support to rustfm-scrobble, and have one unified crate.

@shymega
Copy link

shymega commented Jul 23, 2021

@InputUsername
Copy link
Owner

@shymega I've got an existing listenbrainz crate, but I agree that turning rustfm-scrobble into a unified scrobbler sounds appealing as well.

@shymega
Copy link

shymega commented Jul 23, 2021

@InputUsername Yeah, I'll wait for the author of rustfm-scrobble to get back to me. I think that crate will need a bit of refactoring though. Depends on what the author wants to do... or we could make a fork?

The problem really is that its very much designed for Last.fm, and whilst Libre.fm would generally fit in quite well, Listenbrainz is a very different beast!

Thanks for the quick reply... 👍

@InputUsername InputUsername modified the milestone: v0.5.0 Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants