Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MenuType 및 BoardType 재설계 진행 #290

Open
skytin1004 opened this issue Apr 8, 2024 · 0 comments
Open

MenuType 및 BoardType 재설계 진행 #290

skytin1004 opened this issue Apr 8, 2024 · 0 comments
Assignees
Labels
refactor Upgrade to better features

Comments

@skytin1004
Copy link
Member

skytin1004 commented Apr 8, 2024

/board/:menuId/:boardId/comment 여기서 /board/:boardType(또는 menuType)/:boardId/comment 로 바꾸려고 했는데 (현재는 우선 menuId로 사용하는 상태)

boardType이 게시판 종류별로 분산되어있고, menuType에서는 menuType을 통해 menuId를 반환할 수 있는 생성자가 없습니다.

또한 두 코드가 중복되고 있어서, menuType과 boardType을 통합할 수 있는 방안을 생각해 봐야할 것 같습니다.

우선 /board/:menuId/:boardId/comment 여기서 /board/:boardType(또는 menuType)/:boardId/comment로 바꾸는건 설계 논의 하고 수정사항 반영 될 때까지 /board/:menuId/:boardId/comment로 구현하기로 했습니다.

@skytin1004 skytin1004 added the refactor Upgrade to better features label Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Upgrade to better features
Projects
None yet
Development

No branches or pull requests

2 participants