Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: extend NO_SCROLLBAR with horizontal/vertical options #653

Open
Ryder17z opened this issue Jun 18, 2024 · 10 comments
Open

Comments

@Ryder17z
Copy link
Contributor

Sometimes a scrollbar can appear that has no effect because it scrolls 0px in that direction. The same is true for very small "scrollable distances" like a couple of pixels.

Thus it would be nice to be able to disable just one of the scrollbars and keep the other if the content inside is big enough to require it.

@RobLoach
Copy link
Contributor

Could you provide an example to debug?

@Ryder17z
Copy link
Contributor Author

I'm working on a tool with a layout of 3 columns and here is an example that renders the same issue with a lot less code:
https://gist.github.com/Ryder17z/402376fa1a509269363182724c1ef922
this example just uses sdl_render

@zoogies
Copy link

zoogies commented Aug 15, 2024

I'm also experiencing the same behavior of some occasional 0px horizontal scrollbars using the SDL renderer.

Just bumping this for now, but in the future I would love to see this fixed. If I get the time I could tackle it myself if needed.

@RobLoach
Copy link
Contributor

I ran the above demo you provided, and it does seem suspect. Resizing the window by 1 pixel either shows or hides the horizontal scrollbar, and there's also some scrollbar padding on the right-hand side....

Screenshot from 2024-08-15 12-52-02

@Ryder17z
Copy link
Contributor Author

I'm also experiencing the same behavior of some occasional 0px horizontal scrollbars using the SDL renderer.

Just bumping this for now, but in the future I would love to see this fixed. If I get the time I could tackle it myself if needed.

Bumping doesn't really work given how Github works and for this repo there is no "stalebot" to worry about.

@zoogies
Copy link

zoogies commented Aug 15, 2024

Bumping = expressing I experience the same thing and putting it back on Rob's radar.

Maybe "nudging" is more appropriate :)

@PROP65
Copy link
Contributor

PROP65 commented Sep 8, 2024

#686

@zoogies
Copy link

zoogies commented Sep 8, 2024

#686

This could be useful for some, but I don't think it fundamentally solves this specific problem

@Ryder17z
Copy link
Contributor Author

Ryder17z commented Sep 8, 2024 via email

@Ryder17z
Copy link
Contributor Author

I ran the above demo you provided, and it does seem suspect. Resizing the window by 1 pixel either shows or hides the horizontal scrollbar, and there's also some scrollbar padding on the right-hand side....

Screenshot from 2024-08-15 12-52-02

Come to think of it, the color picker widget also seem to have a weird padding issue like that, possibly related.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants