Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Mozilla Firefox browser #58

Open
ImMattDavison opened this issue Oct 4, 2022 · 15 comments
Open

Support Mozilla Firefox browser #58

ImMattDavison opened this issue Oct 4, 2022 · 15 comments
Labels
hacktoberfest This issue is ready for hacktoberfest! help wanted Extra attention is needed

Comments

@ImMattDavison
Copy link
Owner

create a conversion of this extension for mozilla firefox
@ImMattDavison ImMattDavison added hacktoberfest This issue is ready for hacktoberfest! help wanted Extra attention is needed labels Oct 4, 2022
@ImMattDavison ImMattDavison changed the title Suppport Mozilla Firefox browser Support Mozilla Firefox browser Oct 4, 2022
@gavinroderick
Copy link

hey, I'd like to pick this up if that's ok?

@ImMattDavison
Copy link
Owner Author

hey, I'd like to pick this up if that's ok?

Assigned!

@gavinroderick
Copy link

damn that was speedy! 🏎️

@ImMattDavison
Copy link
Owner Author

damn that was speedy! 🏎️

🏎️💨

@codingfarhan
Copy link

Hi, what's the status? Can I help in any way? I'm open to fixing any issue in the project so please let me know.

@gavinroderick
Copy link

Hey @codingfarhan I picked this up and started looking - i think it's probably a bit above what I have capacity to do rn, happy if you want to pick it up and try it!

cc. @ImMattDavison

@gavinroderick gavinroderick removed their assignment Oct 7, 2022
@ImMattDavison
Copy link
Owner Author

Hey @gavinroderick there is already a PR for this, it just needs rearranging so that MV2 and MV3 versions are separated, I can work on it over the weekend unless you want to?

@gavinroderick
Copy link

yeah I looked at the PR, I'll be honest I don't have any experience with extensions and figured this would be a nice place to start! works been super draining this week so i don't think i'll be working on it, sorry!

@ImMattDavison
Copy link
Owner Author

yeah I looked at the PR, I'll be honest I don't have any experience with extensions and figured this would be a nice place to start! works been super draining this week so i don't think i'll be working on it, sorry!

That's fair enough, thanks for your help!

@codingfarhan
Copy link

Late here, but I would love to pick up on the issue. @ImMattDavison can I still work on this?

@ImMattDavison
Copy link
Owner Author

Late here, but I would love to pick up on the issue. @ImMattDavison can I still work on this?

For sure - please not FireFox requires MV2 - the best option would be to put all current files into a folder called MV3 and make another version with the same functions in a folder named MV2 of course leave README and other similar files in the root dir

@ImMattDavison
Copy link
Owner Author

@codingfarhan #61 may be a good starting point!

@codingfarhan
Copy link

@codingfarhan #61 may be a good starting point!

Thanks, I'll get right into it.

@ImMattDavison
Copy link
Owner Author

@codingfarhan #61 may be a good starting point!

Thanks, I'll get right into it.

Thanks! Looking forward to your PR!

@codingfarhan
Copy link

Facing difficulty implementing MV2 for Firefox, I may not be able to do it. Sorry guys. Please look over it @ImMattDavison

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hacktoberfest This issue is ready for hacktoberfest! help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gavinroderick @codingfarhan @ImMattDavison