Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default database.options gets overridden & fails config validation #726

Closed
yhabteab opened this issue Apr 2, 2024 · 1 comment · Fixed by #731
Closed

Default database.options gets overridden & fails config validation #726

yhabteab opened this issue Apr 2, 2024 · 1 comment · Fixed by #731
Labels
bug Something isn't working
Milestone
1.2.0

Comments

@yhabteab
Copy link
Member

yhabteab commented Apr 2, 2024 •
edited
Loading

Describe the bug

We need to comment out database.options until the goccy/go-yaml upstream branch is merged and released. Otherwise, Icinga DB fails to start with the following validation error.

~/Workspace/go/icingadb (missing-history-index ✗) go run cmd/icingadb/main.go --config config.example.yml
invalid configuration: max_connections cannot be 0. Configure a value greater than zero, or use -1 for no connection limit
exit status 2
@yhabteab yhabteab added the bug Something isn't working label Apr 2, 2024
@julianbrost julianbrost added this to the 1.1.2 milestone Apr 2, 2024
oxzi added a commit that referenced this issue Apr 8, 2024
@oxzi
config.example.yml: Comment out unmodified blocks
f692309 
As reported in #726, the default values for `database.options` are
overwritten by go-yaml. By commenting out the key of the
empty/unmodified YAML dictionary, this bug is mitigated. To make this
change consistent, the keys of all other unmodified dictionary blocks
have also been commented out.

Close #726.
@oxzi oxzi mentioned this issue Apr 8, 2024
Merged
@oxzi
Copy link
Member

oxzi commented Apr 8, 2024

For the record, I build an Icinga DB version with @yhabteab's patch against go-yaml which solved the issue.

However, as a workaround for the upcoming release I just created #731.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
1.2.0
Development

Successfully merging a pull request may close this issue.

config.example.yml: Comment out unmodified blocks Icinga/icingadb
3 participants
@julianbrost @oxzi @yhabteab