Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading to latest ember #43

Open
pdud opened this issue Jan 6, 2023 · 4 comments
Open

Upgrading to latest ember #43

pdud opened this issue Jan 6, 2023 · 4 comments

Comments

@pdud
Copy link
Contributor

pdud commented Jan 6, 2023

Hey IcarusWorks!

We love your add-on and have been using it for years! Thanks so much! 🙌

We're in the midsts of upgrading to Ember 4 and found some add ons that required updating.

I've got three PRs ready to go for ember-cli-deploy-bugsnag

  1. Adding github actions CI (just runs lint) chore: add github actions #41
  2. Adding tests that run successfully in CI chore: add some tests #42
  3. Upgrading to the ember 3.28, which is a breaking change because it drops node support.

Is this something you would be interested in?

@patrickberkeley
Copy link
Member

@pdud great! Thanks for the updates. We're not actively using this addon, but review and merge PRs.

@pdud
Copy link
Contributor Author

pdud commented Jan 6, 2023

Awesome! Thanks so much!

Here are the same PRs on my fork with the passing tests. I'm happy to make any changes you'd like!

https://github.com/pdud/ember-cli-deploy-bugsnag/pulls?q=is%3Apr+sort%3Aupdated-desc+

@pdud
Copy link
Contributor Author

pdud commented Jan 13, 2023

Hi @patrickberkeley! Thanks so much for your fast reply and time on this.

Before I ask if you'd be able to cut a release, I want to confirm on my end that this branch has everything it needs to support Ember 4 I've got 1-2 other addons I need to update first. I'll loop back after.

Thanks again!

@patrickberkeley
Copy link
Member

Sounds good, thanks @pdud. Keep me posted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants