Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Wake-lock for video playbacks #561

Open
redwan3 opened this issue Dec 18, 2024 · 4 comments
Open

[BUG] Wake-lock for video playbacks #561

redwan3 opened this issue Dec 18, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@redwan3
Copy link

redwan3 commented Dec 18, 2024

Just noticed video playbacks don't have wake-lock. Phone automatically gets locked after a set amount of time even if I am watching a video. Hope there is a fix soon.

  • OS: Android 14
  • App Version 3.1.0

**

@redwan3 redwan3 added the bug Something isn't working label Dec 18, 2024
@linuxct
Copy link
Contributor

linuxct commented Dec 23, 2024

Well, the code for this already exists, but for some reason it isn't working on my device either: https://github.com/IacobIonut01/Gallery/blob/main/app/src/main/kotlin/com/dot/gallery/feature_node/presentation/mediaview/components/video/VideoPlayer.kt#L90C5-L96C6

@linuxct
Copy link
Contributor

linuxct commented Dec 23, 2024

I just tried to debug the issue locally to then realize it wasn't happening. I thought it probably wasn't happening due to the debugging, but indeed, with the latest nightly pre-built the problem isn't present there anymore. so I suggest you to download the latest nightly to fix the issue.

@redwan3
Copy link
Author

redwan3 commented Dec 24, 2024

I just tried to debug the issue locally to then realize it wasn't happening. I thought it probably wasn't happening due to the debugging, but indeed, with the latest nightly pre-built the problem isn't present there anymore. so I suggest you to download the latest nightly to fix the issue.

If it's fixed, that's good. But I am not going to install an experimental version just for that. How long will it take for the stable version to be released?

@IacobIonut01
Copy link
Owner

The point of nightly isn't to be experimental, but to release bug fixes and small features / UI improvements early so anyone who reported/suggested the said change will be able to use it early of a full fledge release - which will most likely contain more or less the same changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants