Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Finding JXL images in gallery view #541

Open
Quackdoc opened this issue Nov 30, 2024 · 4 comments
Open

[Enhancement] Finding JXL images in gallery view #541

Quackdoc opened this issue Nov 30, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@Quackdoc
Copy link

Is your feature request related to a problem? Please describe.
JXL files do not currently show up in the gallery and need to be loaded externally

Describe the solution you'd like
Find JXL files in the gallery

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Related to #145 but that is now closed.

Currently it finds TIFF files but those are not supported by the application

@Quackdoc Quackdoc added the enhancement New feature or request label Nov 30, 2024
@Quackdoc
Copy link
Author

Quackdoc commented Nov 30, 2024

I patched val Media.isImage: Boolean get() = mimeType.startsWith("image/") to val Media.isImage: Boolean get() = mimeType.startsWith("image/") || label.substringAfterLast(".").removePrefix(".").equals("jxl", ignoreCase = true) as a testing hack, which means now we can edit jxl images when they get opened, but they still aren't showing up in the gallery view

EDIT: ah is it the albumsflow that handles this?

@IacobIonut01
Copy link
Owner

It's the Android itself that handles which mimeType can be scanned and made visible in the media store - the android database that the app uses.

I think starting with android 14 you are able to see them in the gallery. (I have 15 and they are visible)

@Quackdoc
Copy link
Author

Quackdoc commented Nov 30, 2024

A14 on los and I can't see them, but it seems like to get support on older versions the gallery would need to do custom thumbnailing then? I wonder if there is a way to extend mediastore but afaik that would be no.

EDIT: Actually it seems like it may be possible https://source.android.com/docs/core/media/media-provider#customization do the thumbnails of the image show on A15 or are they black?

@IacobIonut01
Copy link
Owner

Must be from A15 then,

the link you have sent is talking about the MediaProvider customisation on a SYSTEM level, basically modifying the MediaProvider Apex Module to your liking - which is not something I can update on an app level basis.

In order to scan the unsupported mediaTypes on a app level I would have to implement a media scanner - which would force the requirement of the MANAGE_EXTERNAL_STORAGE (full access to your storage) and would make the app unable to function (or required the feature to be removed) on google play

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants