Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default configurations do not validate #5

Open
isthisthat opened this issue Mar 5, 2013 · 6 comments
Open

Default configurations do not validate #5

isthisthat opened this issue Mar 5, 2013 · 6 comments

Comments

@isthisthat
Copy link

Errors remaining:

error - a_study_protein-protein interaction detection_protein microarray.txt
Invalid ISA-TAB: unexpected field Derived Data File found in section transcriptomics_pipeline

warning - a_study_cell sorting_flow cytometry.txt
the column "Image File" (#12) is in a wrong position, or some other column is missing before this. Please check the ISATAB specification.
error - a_study_cell sorting_flow cytometry.txt
Errors in fields order/structure with the file "a_study_cell sorting_flow cytometry.txt", see the log messages for details

warning - a_study_cell counting_flow cytometry.txt
WARNING: The field "Data Transformation Name" should be preceded by the field "Normalization Name"
warning - a_study_cell counting_flow cytometry.txt
the column "Image File" (#12) is in a wrong position, or some other column is missing before this. Please check the ISATAB specification.
error - a_study_cell counting_flow cytometry.txt
Errors in fields order/structure with the file "a_study_cell counting_flow cytometry.txt", see the log messages for details

warning - a_study_protein-DNA binding site identification_DNA microarray.txt
the column "Array Data Matrix File" (#27) is in a wrong position, or some other column is missing before this. Please check the ISATAB specification.
error - a_study_protein-DNA binding site identification_DNA microarray.txt
Errors in fields order/structure with the file "a_study_protein-DNA binding site identification_DNA microarray.txt", see the log messages for details

@eamonnmag
Copy link
Member

Yes, this is now correct. Your file a_study_protein-protein interaction detection_protein microarray.txt needs to be edited and the column Derived Data File should be renamed to Derived Array Data File.

@isthisthat
Copy link
Author

Please have a look at https://github.com/ISA-tools/Configuration-Files/blob/master/isaconfig-default_v2013-02-13/ppi_detection_micro.xml
That file still has it as "Derived Data File".

Please fix the rest of the "warnings" as well. They result to errors preventing the user from passing validation.

Thanks.

@eamonnmag
Copy link
Member

Sorry, I was looking at a different XML file. Updated now. The warnings will not stop validation, they are simply shown alongside errors, if errors appeared. If there are only warnings, validation will be successful, unless validation is 'strict'. I'll have to ask @proccaserra to fix the ordering issues.

thanks!

@isthisthat
Copy link
Author

Hi Eamonn,
Regarding "The warnings will not stop validation, they are simply shown alongside errors, if errors appeared."
You are right. However, in cases where these is a column ordering issue, I've noticed that the warning results into an error. That's why I've particularly included those warnings above (even though there were many more "silent" warnings). You can check for yourself.

@eamonnmag
Copy link
Member

Sure, and we'll sort those existing problems with validation asap. Thanks for your patience. Are your other problems solved now?

@isthisthat
Copy link
Author

OK for now!
Cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants