Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AmeliaView - Wrong implementation of splinetime parameter #29

Open
LutzDE opened this issue Jun 28, 2022 · 0 comments
Open

AmeliaView - Wrong implementation of splinetime parameter #29

LutzDE opened this issue Jun 28, 2022 · 0 comments

Comments

@LutzDE
Copy link

LutzDE commented Jun 28, 2022

Bug based on AmeliaView 1.8:

In AmeliaView it is possible to choose the splinetime= Parameter as "Splines" with knots from zero to ten.

Amelia is called with the parameter values from 0 to 10. But these parameters are used in a different definition (as seen below).
Short: The number of knots is limited to three and has to be translated into the values 4,5 and 6.
On the other hand, if you want a polynominal of time the values 1,2 and 3 are possible values.

Source: help function to amelia()

"splinetime:
interger value of 0 or greater to control cubic smoothing splines of time. Values between 0 and 3 create a simple polynomial of time (identical to the polytime argument). Values k greater than 3 create a spline with an additional k-3 knotpoints."

How to test/check:

Just use the entry 10 knots, which leads to an error.
Read the debug-log-file for amelia() call.

Impact/Conclusion:

Menue_SplineTime
error

Normaly a simple typo is no problem, but in this case it's different.
Using AmeliaView() with ts without knowing this bug, leads into wrong documentation of the used functions and modell.
Conclusions from such work should be checked and reviewed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant