Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Planned Landuse: Test "lu-gml.a.1: Land Use feature in dataset" fails with nested FeatureCollections in XML #930

Closed
ulbrichtd opened this issue Mar 9, 2023 · 3 comments
Labels
deployed in reference validator Solution deployed in production
Milestone

Comments

@ulbrichtd
Copy link

Hi,

the test "lu-gml.a.1: Land Use feature in dataset" validates that featuretypes from Landuse application schema are present in the dataset, i.e. it scans for occurences of plu:SpatialPlan, plu:SupplementaryRegulation and others in the XML. Currently this test does not work with nested FeatureCollections.

Nested FeatureCollections are generated by Geoserver-WFS when you query for more than one featuretype. The data structure looks like this and the INSPIRE validator does not find "plu:SpatialPlan":

<wfs:FeatureCollection>
  <wfs:member >
   <wfs:FeatureCollection>
    <wfs:member >
     <plu:SpatialPlan>…</plu:SpatialPlan>
    </wfs:member>
   </wfs:FeatureCollection>
 </wfs:member>
</wfs:FeatureCollection>

Currently the INSPIRE validator expects this data structure:

<wfs:FeatureCollection>
  <wfs:member >
   <plu:SpatialPlan>…</plu:SpatialPlan>
  </wfs:member>
</wfs:FeatureCollection>

The INSPIRE validator should accept nested FeatureCollections.

You can access our data here WFS-GetFeature

The test report you can find here PLU_nested_featurecollection.zip

There is a similar issue in the ets-repository that discusses this problem for other INSPIRE data themes.

Best regards and many thanks
Damian

@fabiovinci
Copy link
Collaborator

Dear @ulbrichtd,

thank you for the issue.
Looking at the related issue it seems a solution was already provided for the Annex I data themes, so we will check it and implement the same fix for this data theme.

@arantzaetxebarria
Copy link
Collaborator

Dear @ulbrichtd

We have uploaded a solution for this issue in staging environment, could you please verify? Thanks

Regards

@arantzaetxebarria arantzaetxebarria added ready for testing Solution provided to reporter or developed & deployed in staging (or beta), waiting for testing and removed under development labels Mar 14, 2023
@arantzaetxebarria arantzaetxebarria added this to the v2023.1 milestone Mar 14, 2023
@ulbrichtd
Copy link
Author

Hi,

I just tested. The problem is fixed in the staging environment. Thank you.

Best regards
Damian

@arantzaetxebarria arantzaetxebarria added solved Solution developed and accepted, not yet deployed and removed ready for testing Solution provided to reporter or developed & deployed in staging (or beta), waiting for testing labels Mar 14, 2023
@fabiovinci fabiovinci removed their assignment Mar 14, 2023
@fabiovinci fabiovinci added deployed in reference validator Solution deployed in production and removed solved Solution developed and accepted, not yet deployed labels Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed in reference validator Solution deployed in production
Projects
None yet
Development

No branches or pull requests

4 participants