Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Production issues with GML validation #203

Closed
carlospzurita opened this issue Jan 27, 2020 · 5 comments
Closed

Production issues with GML validation #203

carlospzurita opened this issue Jan 27, 2020 · 5 comments
Labels
deployed in reference validator Solution deployed in production
Milestone

Comments

@carlospzurita
Copy link
Contributor

Since some days ago, we have been experiencing some problems in the INSPIRE validator. This problems are related to an issue with the GML validation. There is a bug with the srsName and srsDeclaration detection from the gml:posList tag. By default the dimension is set to 2, and this provokes an error in the geometry parsing that throws an uncontrolled exception, and it ends in a memory leak.

We are working on a hotfix for this issue, but for now, it would be advisable to include the attributes srsName and srsDimension not only on the wrapping Geometry tag, but also on the gml:posList tag. This prevents the memory issues from happening and the validation can be performed.

We have an open discussion for this issue on the bugfix repository etf-validator/etf-webapp#214 , which you can use as a technical reference.

Dear @DeordD , we have found references to the state Baden-Württemberg (BW) in some of the datasets that were related to this issue. Do you have any information on the user that is submitting the datasets, and maybe propose the workaround of the srsDimension?

@ghost
Copy link

ghost commented Feb 4, 2020

Dear @carlospzurita, @MarcoMinghini

thanks a lot for the information.

Dear @DeordD , we have found references to the state Baden-Württemberg (BW) in some of the datasets that were related to this issue. Do you have any information on the user that is submitting the datasets, and maybe propose the workaround of the srsDimension?

This is already communicated to the user which submitted the dataset. GML dataset won't be validated until this problem is fixed.

Kind regards

@carlospzurita
Copy link
Contributor Author

carlospzurita commented Feb 11, 2020

We have uploaded a workaround for this issue on staging . During validation, we take the srsDimension declared on the parent node of the GML entity, and we include it on the gml:posList if it exists. This way we prevent the exception in parsing the geometry. This is a temporary solution, and needs to be further analyzed, but at least you can submit your GML datasets to staging, check the results and share some feedback about the workaround.

@carlospzurita carlospzurita added the ready for testing Solution provided to reporter or developed & deployed in staging (or beta), waiting for testing label Feb 11, 2020
@josemasensio josemasensio added this to the v2020.1 milestone Feb 26, 2020
@carlospzurita
Copy link
Contributor Author

Dear @DeordD
Did you or you're data providers had the opportunity to validate the GML with the problematic CRS, an check if the solution works fine?

@carlospzurita carlospzurita assigned ghost Mar 12, 2020
@ghost
Copy link

ghost commented Mar 12, 2020

Dear @carlospzurita ,

data provider has tested the same GML dataset on staging instance against following CCs:

grafik

Following problem

this provokes an error in the geometry parsing that throws an uncontrolled exception, and it ends in a memory leak.

didn't occur. GML Validation was fully performed.

Thanks a lot for the fix.

@danielnavarrogeo danielnavarrogeo added the solved Solution developed and accepted, not yet deployed label Mar 12, 2020
@danielnavarrogeo danielnavarrogeo removed the ready for testing Solution provided to reporter or developed & deployed in staging (or beta), waiting for testing label Mar 12, 2020
@danielnavarrogeo
Copy link
Contributor

Thank you @DeordD for the feedback.

Regards

@danielnavarrogeo danielnavarrogeo added deployed in reference validator Solution deployed in production and removed solved Solution developed and accepted, not yet deployed labels Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed in reference validator Solution deployed in production
Projects
None yet
Development

No branches or pull requests

3 participants