-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump scikit-learn version to 1.6 #789
Comments
Not sure about the implications on the FUN MOOC if any, but I'll let you deal with this 😉 |
Thinking about it more, I guess for now none of our notebooks actually need scikit-learn 1.6 but oh well ... |
Pinging @brospars for the Jupyter image update :)
Not necessarily 1.6, but #772 needs 1.4, (until now, we used to run on 1.3) |
I seem to remember in FUN-MOOC the environment is created when the user starts its first notebook. I don't remember if there was a way for the user to update its environment but @brospars is indeed the one that may know 😉.
This does not matter too much but just to be 100% explicit. 1.3 is our minimum version requirement |
The notebook image is this one : https://hub.docker.com/r/brospars/singleuser-scikit-learn-mooc (source : https://github.com/inrialearninglab/singleuser-scikit-learn-mooc) I disabled auto updates last year to prevent potential errors due to breaking changes. If I run the pipeline to update dependencies. This will run these lines : FROM jupyter/scipy-notebook:notebook-6.5.4
# [...]
# Install mooc requirements
RUN wget https://raw.githubusercontent.com/INRIA/scikit-learn-mooc/master/requirements.txt
RUN python3 -m pip install --no-cache -r requirements.txt And every user will have the updated version upon the next startup of their environment. Do I proceed ? |
I would wait at least for scikit-learn 1.6.1 to be released, which will happen soonish (I have not followed closely but I would say a week or so). About the answer to "should we update the scikit-learn version in the MOOC JupyterHub?", the conservative part of me is a bit 🤔 "if it's not broken, don't fix it". The adventurous part of me is like "once scikit-learn 1.6.1 is released why not, what could possibly go wrong?". Having said that, once the change is done in the MOOC JupyterHub, it would be nice to test a few notebooks manually and make sure everything seems to work smoothly. |
That was exactly my thought 😅 but 1.4 seems to be required by #772
Yes I will do that first on my eprsonnal env and then deploy it for everyone |
Update : all "solution notebooks" seems to be running fine on 1.6.0. Once 1.6.1 is out I will deploy it. |
Thanks for checking 🙏! By "solution notebooks" you mean with those with Maybe @ArturoAmorQ has some suggestions for some computationally heavy notebooks that would be good to test as well. |
I meant |
Thanks for the check! I'll have a run of the wrap-up quizzes to confirm everything works as expected with 1.6. I'll ping you when it's done @brospars. |
We currently use scikit-learn v1.3, but #772 requires v1.4. Updating scikit-learn to its latest version (v1.6) will allow us to give a better maintenance to the mooc.
On FUN, updating the Jupyter image of the students seems to suffice.
The text was updated successfully, but these errors were encountered: