Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mirroring of a mapping set should honour the MIR variable #1046

Open
gouttegd opened this issue Apr 8, 2024 · 1 comment
Open

Mirroring of a mapping set should honour the MIR variable #1046

gouttegd opened this issue Apr 8, 2024 · 1 comment
Labels

Comments

@gouttegd
Copy link
Contributor

gouttegd commented Apr 8, 2024

Declaring a SSSOM set in maintenance mode as follows:

sssom_mappingset_group:
  products:
    - id: fbbt
      maintenance: mirror
      mirror_from: http://purl.obolibrary.org/obo/fbbt/fbbt-mappings.sssom.tsv

yields the following code in the generated Makefile:

$(MAPPINGDIR)/fbbt.sssom.tsv:
    wget "http://purl.obolibrary.org/obo/fbbt/fbbt-mappings.sssom.tsv" -O $@

in which the mapping set is downloaded unconditionally.

Mirroring a mapping set should obey to the same rules as mirroring an imported ontology. In particular, when MIR is set to false, no attempt to download the remote set should be made.

@gouttegd gouttegd added the bug label Apr 8, 2024
@matentzn
Copy link
Contributor

matentzn commented Apr 9, 2024

Agreed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants