Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need QC for %s #56

Open
matentzn opened this issue Sep 4, 2020 · 0 comments
Open

Need QC for %s #56

matentzn opened this issue Sep 4, 2020 · 0 comments
Assignees

Comments

@matentzn
Copy link
Collaborator

matentzn commented Sep 4, 2020

One of the most important pain points during validation is cases when I am using % instead of %s in pattern strings strings. Example:

name:
  text: "% adenoma"
  vars:
    - v0

def:
  text: "A adenoma that involves the %."
  vars:
    - v0

This should be carefully QCed, by taking also into account the number of variables in the subsequent vars section; This could avoid mistakenly flagging up cases like like

def:
  text: "A adenoma that involves at least 90% the %s."
  vars:
    - v0

or

def:
  text: "A adenoma that involves at least 90 % the %s."
  vars:
    - v0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants