Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simple tester should flag missing annotation property binding #54

Open
matentzn opened this issue Sep 4, 2020 · 4 comments
Open

simple tester should flag missing annotation property binding #54

matentzn opened this issue Sep 4, 2020 · 4 comments

Comments

@matentzn
Copy link
Collaborator

matentzn commented Sep 4, 2020

annotations:
  - annotationProperty: oio:hasExactSynonym
    text: "acquired %s"
    vars:
     - disease

I dont know why, but this all by itself is rejected by dosdp tools (so I assume the spec rejects this)

This is accepted:

annotationProperties:
  exact_synonym: oio:hasExactSynonym 

annotations:
  - annotationProperty: exact_synonym
    text: "acquired %s"
    vars:
     - disease

@dosumis can you confirm which is at fault, the spec or DOSDP tools?

@dosumis
Copy link
Collaborator

dosumis commented Sep 4, 2020

Properties, like classes, need to be declared before they are used.

There's a simpler built-in short cut for oio APs corresponding to OBO tags though. You can just use this tag directly:

https://github.com/INCATools/dead_simple_owl_design_patterns/blob/master/spec/DOSDP_schema_full.yaml#L369 This should work:

generated_synonyms:
   - 
      text: "acquired %s"
      vars: 
         - disease

(Corrected)

@matentzn
Copy link
Collaborator Author

matentzn commented Sep 4, 2020

Ok! Then we need to make sure that simple-tester warns about the first case! Right now, they are ignored

@matentzn
Copy link
Collaborator Author

matentzn commented Sep 4, 2020

Along the same lines, we need to be warned of this case:

classes:
    acquired: MONDO:0021141

vars:
    disease: owl:Thing

(a VAR referring to something that is not declared in classes.

@dosumis
Copy link
Collaborator

dosumis commented Sep 4, 2020

Note to self: Should be possible to use JPATH to fix both.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants