Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several versions of JSON-LD context? #273

Open
aisaac opened this issue Aug 1, 2019 · 4 comments
Open

Several versions of JSON-LD context? #273

aisaac opened this issue Aug 1, 2019 · 4 comments
Assignees

Comments

@aisaac
Copy link
Member

aisaac commented Aug 1, 2019

While checking the implementation of the new mapping for "profile" and related elements I found that the official JSON context is at
https://iiif.io/api/presentation/3/context.json
but there is still an old context at
https://iiif.io/api/presentation/3/combined-context.json
which actually doesn't reflect PR IIIF/api#1722 (considering that this PR seems to be for the 'combined context' file).

@azaroth42 azaroth42 transferred this issue from IIIF/api Aug 1, 2019
@azaroth42
Copy link
Member

Thanks Antoine!

This seems to be a deployment issue, as the combined-context file is not in the master branch:
https://github.com/IIIF/api/tree/master/source/api/presentation/3

Transferred the issue to website and assigned to Glen for investigation.

@glenrobson
Copy link
Member

Hi Rob, is this just a case of deleting the combined-context.json? (just checking I've understood correctly).

@azaroth42
Copy link
Member

Yes ... but that's just a symptom of the issue. The file isn't in the master branch any more and hence shouldn't be being deployed. Does the deployment script only update files, and not check for deletions?

@glenrobson
Copy link
Member

Your right the deployment script only adds and updates not delete. I've manually deleted it for now but will look into fixing the deployment scripts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants