Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recovery rate calculation #449

Open
jzanetti opened this issue Apr 23, 2023 · 2 comments
Open

recovery rate calculation #449

jzanetti opened this issue Apr 23, 2023 · 2 comments

Comments

@jzanetti
Copy link

Hi JUNE developers:

There are lines of codes defining the probability of person who recovers in the ward (see Link for details), for example,

p[population][sex][age][3] = (
    hospital_rate - hospital_dead_rate
)

Should the max function be applied to ensure that the recovery rate is larger than zero ? For example,

p[population][sex][age][3] = max(
    hospital_rate - hospital_dead_rate, 0
) 

Thank you,

Sijin

@arnauqb
Copy link
Member

arnauqb commented Apr 25, 2023

Hi Sijin,

Yes, it would be a good idea to do that. In practice, we make sure that that is the case in the input data, but it would be nice to have it as a check and even print a warning if it finds negative values. If you have the time to submit a PR, I will happily review it.

Cheers

Arnau

@jzanetti
Copy link
Author

jzanetti commented May 3, 2023

Hi Arnau,

I've created a PR here for you to review, thank you.

Regards, Sijin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants