-Wall Warnings

[jmstone]

In GitLab by @pdmullen on Nov 18, 2022, 13:52

Compiling AthenaK issues many warnings when compiling with -Wall flag:

cmake3 -DAthena_ENABLE_MPI=On -Bbuild -D CMAKE_CXX_FLAGS="-Wall"

We should address these. Also, often -Wall flag is good at identifying uninitialized memory. In fact, there are few occurrences in the codebase now, e.g.,

/Users/pdmullen/Desktop/athenak/src/bvals/flux_correct_fc.cpp:68:18: warning: variable 'jl' is used uninitialized whenever 'if' condition is
      false [-Wsometimes-uninitialized]
      } else if (nghbr.d_view(m,n).lev == mblev.d_view(m)) {
                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Users/pdmullen/Desktop/athenak/src/bvals/flux_correct_fc.cpp:78:27: note: uninitialized use occurs here
      const int nj = ju - jl + 1;