From 925aefd7a9aed133ed8ac44a6629dc0c741629a8 Mon Sep 17 00:00:00 2001
From: ZhuHengrui <78500604+HengruiZhu99@users.noreply.github.com>
Date: Wed, 8 Jan 2025 14:07:28 -0500
Subject: [PATCH] fixing bug in the hamiltonian constraint and waveform (#623)

* fixing ricci scalar

* spin for kerr-schild
---
 src/pgen/gr_analytic/kerr_schild.cpp   | 2 +-
 src/z4c/z4c_adm.cpp                    | 4 ++++
 src/z4c/z4c_calculate_weyl_scalars.cpp | 6 +++++-
 3 files changed, 10 insertions(+), 2 deletions(-)

diff --git a/src/pgen/gr_analytic/kerr_schild.cpp b/src/pgen/gr_analytic/kerr_schild.cpp
index da53557f..74921c8b 100644
--- a/src/pgen/gr_analytic/kerr_schild.cpp
+++ b/src/pgen/gr_analytic/kerr_schild.cpp
@@ -79,7 +79,7 @@ void KerrSchild(MeshBlockPack *pmbp, ParameterInput *pin) {
   Real center_x1 = pin->GetOrAddReal("problem", "punc_center_x1", 0.);
   Real center_x2 = pin->GetOrAddReal("problem", "punc_center_x2", 0.);
   Real center_x3 = pin->GetOrAddReal("problem", "punc_center_x3", 0.);
-  Real a = 0;
+  Real a = pin->GetOrAddReal("problem", "punc_spin", 0.);
   bool minkowski = false;
 
   // capture variables for the kernel
diff --git a/src/z4c/z4c_adm.cpp b/src/z4c/z4c_adm.cpp
index ee295d59..21929a40 100644
--- a/src/z4c/z4c_adm.cpp
+++ b/src/z4c/z4c_adm.cpp
@@ -422,6 +422,10 @@ void Z4c::ADMConstraints(MeshBlockPack *pmbp) {
             - ddg_dddd(c,d,a,b) - ddg_dddd(a,b,c,d) +
               ddg_dddd(a,c,b,d) + ddg_dddd(b,c,a,d));
       }
+    }
+
+    for(int a = 0; a < 3; ++a)
+    for(int b = 0; b < 3; ++b) {
       R += g_uu(a,b) * R_dd(a,b);
     }
 
diff --git a/src/z4c/z4c_calculate_weyl_scalars.cpp b/src/z4c/z4c_calculate_weyl_scalars.cpp
index 567107d6..2e8b0942 100644
--- a/src/z4c/z4c_calculate_weyl_scalars.cpp
+++ b/src/z4c/z4c_calculate_weyl_scalars.cpp
@@ -208,7 +208,11 @@ void Z4c::Z4cWeyl(MeshBlockPack *pmbp) {
             - ddg_dddd(c,d,a,b) - ddg_dddd(a,b,c,d) +
               ddg_dddd(a,c,b,d) + ddg_dddd(b,c,a,d));
       }
-        R += g_uu(a,b) * R_dd(a,b);
+    }
+
+    for(int a = 0; a < 3; ++a)
+    for(int b = 0; b < 3; ++b) {
+      R += g_uu(a,b) * R_dd(a,b);
     }
 
     // -----------------------------------------------------------------------------------