Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change th-TH culture to th #1522

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Change th-TH culture to th #1522

wants to merge 1 commit into from

Conversation

MarkusG
Copy link

@MarkusG MarkusG commented Jul 3, 2024

Web browsers (at least Firefox and Chromium) only send th in the Accept-Language header, leading ASP.NET to select it as the current culture. This leads to Humanizer failing to find the resource and consequently falling back to the default culture. Renaming the resource files to the more generic language/culture specifier fixes the issue.

Here is a checklist you should tick through before submitting a pull request:

  • Implementation is clean
  • Code adheres to the existing coding standards; e.g. no curlies for one-line blocks, no redundant empty lines between methods or code blocks, spaces rather than tabs, etc.
  • No Code Analysis warnings
  • There is proper unit test coverage
  • If the code is copied from StackOverflow (or a blog or OSS) full disclosure is included. That includes required license files and/or file headers explaining where the code came from with proper attribution
  • There are very few or no comments (because comments shouldn't be needed if you write clean code)
  • Xml documentation is added/updated for the addition/change
  • Your PR is (re)based on top of the latest commits from the main branch (more info below)
  • Link to the issue(s) you're fixing from your PR description. Use fixes #<the issue number>
  • Readme is updated if you change an existing feature or add a new one
  • Run either build.cmd or build.ps1 and ensure there are no test failures

I'm developing on Linux and can't seem to get the project to build and test, so I'm hoping CI can bail me out.

Web browsers (at least Firefox and Chromium) only send th in the
Accept-Language header, leading ASP.NET to select it as the current
culture. This leads to Humanizer failing to find the resource and
consequently falling back to the default culture. Renaming the resource
files to the more generic culture specifier fixes the issue.
@MarkusG
Copy link
Author

MarkusG commented Jul 3, 2024

@dotnet-policy-service agree company="Roland DGA"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant