Skip to content

Latest commit

 

History

History
56 lines (40 loc) · 3.92 KB

DEV_README.md

File metadata and controls

56 lines (40 loc) · 3.92 KB

Slack Web API Breaking Changes

license GitHub last commit Build Status GitHub release Maven metadata URI

Overview

Every so often, companies will issue “breaking changes” whether they’re officially calling them that or not. You can think of a breaking change as any modification or deletion of an api endpoint that would adversely affect the slack-client.

The main reason for this process is to be proactive and prevent possible future bugs in the slack-client.

Changelogs

There are 2 changelogs: current and future.

The former contains recent changes and dates on when an endpoint will be changed in a possible breaking way. The latter shows proposed future changes.

Both should be read through when determining if the changes affect us.

Audit

The following is a list of proposed steps to take in order to make sure that slack-client stays stable and on the latest working Slack Web API.

  • Read the docs above for possible “breaking changes”. It's generally a good idea to go back a few months and see if anything changed. See History and don't revisit the same stuff.
  • Look for red APIs found throughout their docs above. These indicate the change could be breaking.
  • Every month, generate a list of changes to look out for.Make sure that the prior months' lists didn't already include the same breaking change. We don’t want to verify the same change twice.
  • For each change, we should audit the slack-client code and see if it affects us.
  • If we find anything that requires further investigation or actual code changes, an issue should be logged here with the label breaking change.
  • If HubSpot is making the change, it's recommended that an internal ZenHub task is created to track this as well. Reference the github issue above.
  • We should aim to wrap up issues with several weeks to spare. If a deadline for a breaking change is the end of June, we should have something ready in early June if at all possible.
  • We should add a record of this audit to History table. Make sure to document where in changelog docs you went to so we can reference next time and not revisit.

History

Date Found Issues Description
20190702 One small deprecation Audited up to July 08 2019 tasks in https://api.slack.com/changelog/future
20190702 Replies deprecation Audited up to June 2019 section https://api.slack.com/changelog/
20190805 1000 count limit already done Audited up to Effective August 30, 2019 change in https://api.slack.com/changelog/future
20190805 No deprecations Audited up to July 2019 section https://api.slack.com/changelog/
20190905 Surprise deprecation in reactions.add effective Aug 22 https://api.slack.com/changelog/future
20190905 Already on TLS 1.2 TLS 1.2 section in https://api.slack.com/changelog
20191007 N/A through Aug 30th limit change https://api.slack.com/changelog/future
20190905 Not breaking, but WYSIWYG text editing means we can now import rich text formatting. Created #659 WYSIWYG section https://api.slack.com/changelog