Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

properties type definition seems incomplete #553

Open
arasmussen opened this issue Oct 25, 2024 · 0 comments
Open

properties type definition seems incomplete #553

arasmussen opened this issue Oct 25, 2024 · 0 comments

Comments

@arasmussen
Copy link

In SimplePublicObjectInputForCreate or SimplePublicObjectInput, properties is defined as:

    'properties': {
        [key: string]: string;
    };

This seems incompatible with HubSpot's properties, which can be dates, booleans, numbers, or null...

I can definitely convert:

  • number → number.toString()
  • boolean → String(boolean)
  • null → ''
  • date → date.toISOString()

But it seems like @hubspot/api-client should accept all primitives types and do the conversion on its side if you truly require it...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant