Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openjdk: test build with llvm@17 #190817

Closed
wants to merge 4 commits into from
Closed

openjdk: test build with llvm@17 #190817

wants to merge 4 commits into from

Conversation

carlocab
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Let's test whether this builds with llvm@17 to help track down the
build failure with Apple Clang 16.

@carlocab carlocab added CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-skip-dependents Pass --skip-dependents to brew test-bot. CI-no-bottles Merge without publishing bottles labels Sep 16, 2024
@carlocab carlocab requested a review from Bo98 September 16, 2024 14:38
@github-actions github-actions bot added the CI-build-dependents-from-source Pass --build-dependents-from-source to brew test-bot. label Sep 16, 2024
@carlocab carlocab force-pushed the openjdk-failure branch 2 times, most recently from 8b4656e to 6b50612 Compare September 16, 2024 15:21
@carlocab
Copy link
Member Author

Let's test whether this builds with `llvm@17` to help track down the
build failure with Apple Clang 16.
@Bo98
Copy link
Member

Bo98 commented Sep 16, 2024

Current theory is an optimisation bug. Seems to not happen with slowdebug which I think uses -O0. Not sure which -O level triggers it.

@carlocab
Copy link
Member Author

Ok, will add -Os to cflags and cxxflags next to see

@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Sep 16, 2024
Formula/o/openjdk.rb Outdated Show resolved Hide resolved
Formula/o/openjdk.rb Show resolved Hide resolved
@cho-m
Copy link
Member

cho-m commented Sep 16, 2024

May be related root cause for OpenJDK 11 and 17, though for those a JVM crash happens during build. From local attempt for OpenJDK 17, need to go down to -O1 to avoid (though hard to test other LLVM since older OpenJDK uses a header that is not shipped in brew LLVM).

@Bo98
Copy link
Member

Bo98 commented Sep 16, 2024

Yeah seems to be -O2. Trying to pin it down further to a specific optimisation pass or what bit of code is failing but haven't gotten anywhere yet.

The default is -O3 for certain performance critical parts of the JVM so -O1 would be a big drop.

@Bo98
Copy link
Member

Bo98 commented Sep 16, 2024

With that said, if it's crashing in OpenJDK 17 it might be easier to debug properly there rather than it raising Java errors.

Copy link
Contributor

github-actions bot commented Oct 8, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale No recent activity label Oct 8, 2024
@carlocab carlocab closed this Oct 8, 2024
@carlocab carlocab deleted the openjdk-failure branch October 8, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosquash Automatically squash pull request commits according to Homebrew style. CI-build-dependents-from-source Pass --build-dependents-from-source to brew test-bot. CI-no-bottles Merge without publishing bottles CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-skip-dependents Pass --skip-dependents to brew test-bot. stale No recent activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants