-
-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
brew bundle add && brew bundle remove #818
Comments
Adding and removing feels like a step below what you want, right? Presumably you want a way of keeping your ( |
I do want to modify my global I'm less keen on doing a |
I'm thinking it would be
Hmm, so a selective dump is desired, effectively? |
I actually like that better. Then no flag is needed,
Yeah. The delta of packages that were added in the |
So a question about this. How would My thought is that |
Yes, that makes sense. Annoyingly this probably needs a new name like |
Another option might be to have So, That might be too cumbersome to type, so you could invert it by having |
Makes sense to me 👍🏻 |
I like that too. I'll give the implementation a go, any pointers or non-obvious requirements? |
Thanks, @johndbritton! As always, feel free to open a PR if you're stuck and need some guidance! |
Hi guys, what happened to the PR for this? |
@primeapple it went stale. |
I'm also interested in this. I was trying to use the environment variables for skipping install, My current use-case is that I don't want macOS games that are listed by
Would a configuration file such as |
For the skip env_vars, we could allow users to customize the character to split on with another environment variable, but this doesn't solve problem 1 in my previous comment. |
No but I can see an argument that things you're requested be skipped do not get output into a global
I'm less concerned about changing the experience if the new one makes more sense (which I think it would given your proposal).
Use the IDs and not the names. If this doesn't work: it should be fixed and we'd welcome a PR. |
Here's my solution, that learns function brew() {
if [ "$1 $2" = "bundle " ] && ! [ -f Brewfile ]; then
clear
vim ~/.config/Brewfile && brew bundle --file ~/.config/Brewfile --cleanup
return $?
fi
command brew "$@"
} |
Neat. Do you plan to PR? |
Passing on this, sorry John! |
With this feature request closed as not planned, I'd like to present my third-party implementation of this feature. I had the need for these commands around a year ago and I decided to implement them myself. You can find the source code for them at https://github.com/superatomic/homebrew-bundle-extensions and you can install the commands by running |
@superatomic Nice work! This was closed mainly because it'd been open a long time with no activity. Would you be interested in submitting your tap's commands as a PR to this repository? Np if not! |
I would love to submit my tap's commands as a PR to this repository! Looking at the codebase for I do have one concern, which is copyright. I licensed my tap's code under the BSD-2-Clause license, because it is the same license that
Once either of these actions are done, I will adapt the code for this project and submit a PR. |
@superatomic I'm happy to have my contributions to this project be under the MIT License. Most of my repos are MIT licensed anyhow. Let me know if you need anything more formal than this message for proof! |
Thank you; I believe that's good! I'll begin work on the PR. |
Fantastic! Happy to see this functionality potentially get merged into |
Thanks @superatomic and @boldandbrad for both being so quick to respond and willing to be flexible for the Homebrew community 😍. Looking forward to the PR @superatomic. If you get blocked at all or e.g. CI/tests aren't passing yet: feel free to open a draft PR and we'll get there together. Thanks again all! |
This is super awesome of you, thank you so much! |
Apologizes for the delay in progress. I've been busy lately with some personal things and I haven't had time to work on a PR. I should be able to start soon. In the meantime, it might be worthwhile to reopen this issue? |
No rush, thanks @superatomic. |
Quick update! I'm still alive and I am still very interested in creating a PR. I've been having a much busier few weeks than expected but I will hopefully get around to this soon. |
I'm interested in implementing
brew bundle add <formula>
andbrew bundle remove <formula>
commands inhomebrew-bundle
. These commands would add or remove formulae from the brewfile at~/.Brewfile
.Is this a contribution you'd consider accepting and if so do you any implementation suggestions or requirements to have it merged?
In Homebrew/discussions#163 I asked:
It was suggested that a feature like this would be most appropriate in
homebrow-bundle
:The text was updated successfully, but these errors were encountered: