-
-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add shell completions #1166
Comments
Yes, completions could be added into |
I have experience with writing fish shell completion and I would be willing to do so. Unfortunately, I have never written completion for bash or zsh. |
@superatomic Thanks for the offer! I think the ideal for all three types of completions would be to use the |
Took a stab at this and the issue I'm seeing with I understand the preference for automatically generating completions in CI, as expressed in your comment on #1216; would you consider a PR that automates completion generation but doesn't use At a minimum it would be easy enough to make an erb template based on #1216 and fill in the flag help text using |
i believe that there is more complicated way - both and automatically generating completions in CI AND usage of Homebrew::Completions module: at first you need to register all possible command with their descriptions in module, then run shell script generation. But yeah, i didn't finish this cause lack of free time exactly to deal with Homebrew::Completions module 😢 |
@dduugg ☝🏻 as you might find this an interesting area for potential extension or improvement.
This would be more likely to be accepted than anything manual, yeh, particularly if this CI breaks if you add commands and forget to add completions.
Improving the Homebrew/brew support here feels more desirable if possible (and @dduugg may be able to do or help with this). |
Sorry, just catching up on this mention, @MikeMcQuaid. Could I trouble you for concrete examples of sub-commands to help me form a mental model? (Might be useful to do a quick sync on the topic if we can find the time.) I think if I were to sink another large chunk of time into this space, I would work on proper namespaces for |
@dduugg That make sense?
Yeh, this also feels like a nice thing do consider 👍🏻 |
Is there a way to add shell completion for
brew bundle
command?The text was updated successfully, but these errors were encountered: