Skip to content
This repository has been archived by the owner on Nov 13, 2024. It is now read-only.

Questions about modelling #2

Open
simonh1000 opened this issue Nov 18, 2019 · 0 comments
Open

Questions about modelling #2

simonh1000 opened this issue Nov 18, 2019 · 0 comments

Comments

@simonh1000
Copy link

simonh1000 commented Nov 18, 2019

  1. You have, for example,
get : Maybe Operation

where an Operation has a responses field which has space for responses for push, delete etc. Surely there is at most only 1 response for a get?

  1. your Operation parameters looks to be taking just a single parameter, and not a list of parameters as I see in the petshop example

  2. it looks as though you may also have an impossible state in Parameter. I think ParameterBody only makes sense for a ParameterIn of Body. I think you need something like:

type ParameterIn
    = Query
    | Header_
    | Path
    | FormData
    | BodySchema Schema
    | BodyOthers ParameterBodyOthersBody
@simonh1000 simonh1000 changed the title Question about modelling Questions about modelling Nov 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant