Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jest config fix and tunnel client changeover #19

Merged
merged 13 commits into from
Sep 16, 2019
Merged

Jest config fix and tunnel client changeover #19

merged 13 commits into from
Sep 16, 2019

Conversation

kreig303
Copy link
Collaborator

@kreig303 kreig303 commented Apr 12, 2019 •
edited
Loading

  • swapped localtunnel for smee-client per probot org's suggestions
  • added Jest config into package.json to fix testing
  • will attempt to address Test Fails #18 with this

@kreig303
Copy link
Collaborator Author

kreig303 commented Apr 12, 2019 •
edited
Loading

Will need to work on this to fix the travis build.
Hadn't looked at this since December but the tests are obviously heavily borked...

@kreig303 kreig303 closed this Apr 12, 2019
@kreig303 kreig303 reopened this Apr 12, 2019
@kreig303
Copy link
Collaborator Author

kreig303 commented Sep 2, 2019

so @Hollywood am i to understand this contribution is not being integrated?

@Hollywood
Copy link
Owner

Hollywood commented Sep 3, 2019 •
edited
Loading

@kreig303 my apologies, I’ve been beyond swamped and have had zero time to get to this. It definitely should be.

And haha on the package-lock.json commit message. Leave me alone, my JS was obviously rusty when I wrote this 😉😉😉

@Hollywood Hollywood merged commit 418eeb3 into Hollywood:master Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kreig303 @Hollywood