Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reasonable defaults for layouts? #41

Open
4 tasks
amirrajan opened this issue Aug 14, 2016 · 4 comments
Open
4 tasks

reasonable defaults for layouts? #41

amirrajan opened this issue Aug 14, 2016 · 4 comments

Comments

@amirrajan
Copy link
Collaborator

amirrajan commented Aug 14, 2016 •
edited by jjaffeux
Loading

Just a short list I'm keeping for reasonable defaults for different UI components.

  • UI::Button default height?
  • UI::Button default background and foreground color?
  • UI::View default flex/flow direction?
  • default fade in, fade out animations. Maybe this list?: https://daneden.github.io/animate.css/
@jjaffeux
Copy link
Contributor

My idea was to provide a default template implementing material design.

@amirrajan
Copy link
Collaborator Author

Only bring this up because I got tripped on on UI::Button on :tap wire up. I spun my wheels for a little bit because the tap event wasn't firing. It was because the UI::Button didn't have a height.

@jjaffeux
Copy link
Contributor

concerning this specific case we should make sure the button has at least the size of its intrinsic size (text, image)

@jjaffeux
Copy link
Contributor

Should work with this commit on iOS : 79749c7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jjaffeux @amirrajan