Add support for more settings in known fixes .json files

[Alerymin]

Problem description

I want to create a file for Return to Castle Wolfenstein, but I need to change the folder name (because the autogenerated one is broken for some reason) and some environment variables. But I cannot do it.
See: Heroic-Games-Launcher/known-fixes#6

Feature description

Add support for setting as a fix:

• Select Wine version (which should preferably not lead to choosing proton)
• Enable Esync
• Enable Fsync
• Prefer system libraries
• BattleEye AntiCheat
• EasyAntiCheat
• Game arguments
• Wrapper commands
• Environment variables
• Prefered Language

Alternatives

No response

Additional information

All the settings I listed are editable by the user, maybe all of them is not ideal or some may need to be added, but these will help making games work out of the box.

[imLinguin]

(because the autogenerated one is broken for some reason)

What do you mean by this. According to the manifest, the install directory is Return to Castle Wolfenstein/. I think that's set properly

[Alerymin]

When installing, it adds a space after the name, so the folder name ends with a space, which breaks winetricks

[Alerymin]

There is indeed a space in the name

[imLinguin]

oh, so it causes issues with the prefix itself

[Alerymin]

Yes, the issue is in the prefix, and winetricks hates it

[imLinguin]

Ideally we shouldn't save prefix like that into the config in the first place.
That shouldn't be dictated by known-fixes.

[Alerymin]

ok, so this should be fixed in Heroic directly

[arielj]

I think a lot of the suggested items to add to the known fixes don't belong there:

Select Wine version (which should preferably not lead to choosing proton) <-- users should be able use what works better for them, it's not always correct to say one game works better with one type of proton/wine
Prefer system libraries <-- this is in general NOT needed and when needed it's not related to a game issue but to other factors like the wine version, the type of package (we had issues with this for flatpak for example), system dependencies, etc
BattleEye AntiCheat <-- we could instead use the anticheat information we already have available to disable/enable this
EasyAntiCheat <-- we could instead use the anticheat information we already have available to disable/enable this
Game arguments <-- the decision to use this is user-dependent, not game dependent (like skipping a launcher, disabling dx12, etc)
Wrapper commands <-- the decision to use this is user-dependent, not game dependent
Prefered Language <-- the decision to use this is totally user-dependent (heroic should prefer the UI's language of the user, not something in that repo

I think the only ones that would make sense are:

• esync/fsync (only because we know that has created issues with some games in the past like some of the Yakuza games)
• env variables (but only env variables that are for sure a requirement and not a preference)
• if we add something about the wine/proton to use we should only use it to inform the user about an issue and not to force the use of it