-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not load the payments scripts until actually needed #14682
Comments
@negue Hello, I'd be willing to investigate this a bit and see what I can find. Could you let me know the page you were on when stripe and amazon pay were loaded? Was it the home page or another page? |
Hi @lstanford53--let's get your other two PRs into production first before adding something else to your plate. The team also needs to do more investigation on this issue to determine the scope of the fix needed--it may be something we prefer to handle internally. |
I'm not sure about Amazon pay but Stripe recommends adding their JS on all pages for fraud detection.
|
Sorry for the way to late response on this:
the file that is always adding the scripts:
Oh, thats good to know - we might need to investigate that further and see what Amazon recommends, maybe that one can be only used on the page it is actually used We'll need to discuss this internally before continuing on this one |
I saw that on a normal page (nothing with subscription or anything) stripe and amazon pay was loaded
This needs to be pushed to a point where we actually need em
The text was updated successfully, but these errors were encountered: