-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Sendy List ID #976
Comments
@doug-s-nava - Given this has been an open ticket since last Jan. Do you have any objections to pushing it out past the 12/10 deadlines? At that point we'll have a bit of bandwidth to explore rebuilding the account profile to invalidate the one with published data. |
That works for me. I don't think this is particularly pressing. Moving back to the icebox for now. |
Noting for posterity that there are a bunch of details from Doug's investigation here. |
We're likely moving off of Sending in the next quad or so; marking this as won't fix. |
Summary
Sendy recommended hardcoding our sendy url, api key, and list id directly in the html of the application.
While we already removed that from the codebase and from the client browser, the url and list id are still in our github history. While the url likely cannot be changed, we should update the list id to prevent any possible malicious use.
Acceptance criteria
Note that this ticket previously called for rewriting the git history to remove any Sendy secret data. As this was deemed too risky and complex, the AC was updated.
The text was updated successfully, but these errors were encountered: