Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manager Note for Activity Report #138

Closed
5 tasks done
pamlo412 opened this issue Nov 6, 2020 · 2 comments · Fixed by #281
Closed
5 tasks done

Manager Note for Activity Report #138

pamlo412 opened this issue Nov 6, 2020 · 2 comments · Fixed by #281
Assignees
Labels
5 Story Points AR Submit & Approve Issues concerning the Review and Submit section of ARs enhancement New feature or request In epic 5 Issue is a child in the indicated parent epic V1.0 MVP Indicates the release version for the issue

Comments

@pamlo412
Copy link
Contributor

pamlo412 commented Nov 6, 2020

User story:
As a TTA manager reviewing an Activity Report, I want to be able to leave a comment at the end of the report.

Acceptance criteria:

  • The field is optional.
  • Notes from the specialist are viewable in this area above the manager note entry box.
  • Completed notes are labeled as "Manager Notes"
  • Field can handle a large amount of text
  • No formatting available. (ignore bold "Lou-Anne" in notes field in design)

Design:
https://preview.uxpin.com/ad995fd722bd26c0f9a1c8a115f1b41833637308#/pages/134880478/simulate/sitemap

Exclusions:

  • approval of the report, Manager approves an Activity Report #137
  • display of revisions-requested report in the specialist's queue, Display creator/collaborator's work list #181
  • if the manager makes changes directly in the report, there is no indicator of what changed. Only the comments field is separated out to distinguish the manager's feedback
  • we will handle editing of the report by the manager (here or later/elsewhere) via a separate story
@pamlo412 pamlo412 added enhancement New feature or request In epic 5 Issue is a child in the indicated parent epic V1.0 MVP Indicates the release version for the issue labels Nov 6, 2020
@pamlo412
Copy link
Contributor Author

Discussed at standup grooming: we want to complete design review with @PatricePascual-ACF before grooming this story. We may want multiple comment boxes (one per section) rather than one comment box over all.

@pamlo412 pamlo412 added the Needs Design Flag to alert designer label Nov 24, 2020
@matt-dobson
Copy link

@PatricePascual-ACF This is one that might be able to be split by role type. With a story for the manager experience and a story for the specialist experience.

@pamlo412 pamlo412 added the 5 Story Points label Dec 17, 2020
@pamlo412 pamlo412 removed the Needs Design Flag to alert designer label Dec 17, 2020
@marriej marriej added the AR Submit & Approve Issues concerning the Review and Submit section of ARs label Dec 22, 2020
@marriej marriej changed the title Manager-requested revisions workflow for Activity Report Manager Note for Activity Report Dec 22, 2020
@jasalisbury jasalisbury self-assigned this Feb 2, 2021
rahearn pushed a commit that referenced this issue Feb 4, 2021
Create separate docker-compose file for running tests, add bin/run-tests command for easy testing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 Story Points AR Submit & Approve Issues concerning the Review and Submit section of ARs enhancement New feature or request In epic 5 Issue is a child in the indicated parent epic V1.0 MVP Indicates the release version for the issue
Projects
None yet
4 participants