Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework ROOT file reading #108

Open
AndreasAlbert opened this issue Aug 25, 2019 · 0 comments
Open

Rework ROOT file reading #108

AndreasAlbert opened this issue Aug 25, 2019 · 0 comments
Labels
enhancement New feature or request

Comments

@AndreasAlbert
Copy link
Collaborator

Relates to #99

The current purpose of ROOTFileReader is to provide a tool to extract arrays of numbers from histogram and graph axis, or possibly trees. Most of these features are implemented in uproot in a much nicer fashion, so there is no point for us to maintain effectively duplicate code. Instead of using ROOTFileReader as a ROOT-to-array converter, we should use it as a ROOT-to-hepdata_lib.Variable converter.

The following operations can definitely be handled by uproot:

  • TGraph -> array conversion.
  • TH1 -> array conversion.
  • TH2 -> array conversion. Caveat: need 1D array format for dependent variable consistent with what hepdata expects.
  • TTree -> array conversion.

The only operation we need ROOT for would be to retrieve histograms from TCanvas primitives.

@AndreasAlbert AndreasAlbert added the enhancement New feature or request label Aug 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant