fix for created and lastModified keys

Author: jreadey

src/h5json/dset_util.py

@@ -40,7 +40,6 @@ def resize_dataset(dset_json, shape):
             raise ValueError(f"extent for dimension {i} can't be larger than {maxdims[i]}")
 
     shape_json["dims"] = list(shape)
-    dset_json["modified"] = time.time()
 
 
 def getDims(dset_json):

src/h5json/hdf5db.py

@@ -129,9 +129,7 @@ def deleted_objects(self):
 
     def make_dirty(self, obj_id):
         """ Mark the object as dirty and update the lastModified timestamp """
-        if self.is_new(obj_id):
-            # object hasn't been initially written yet, just return
-            return
+
         if obj_id not in self.db:
             self.log.error("make dirty called on deleted object")
             raise KeyError(f"obj_id: {obj_id} not found")
@@ -140,7 +138,9 @@ def make_dirty(self, obj_id):
             return
         obj_json = self.db[obj_id]
         obj_json["lastModified"] = time.time()
-        self._dirty_objects.add(obj_id)
+        if not self.is_new(obj_id):
+            # object hasn't been initially written yet, add to dirt_object set
+            self._dirty_objects.add(obj_id)
 
     def flush(self):
         """ write out any changes """
@@ -646,7 +646,7 @@ def resizeDataset(self, dset_id, shape):
 
         dset_json = self.getObjectById(dset_id)  # will throw exception if not found
         if resize_dataset(dset_json, shape):
-            self._dirty_objects.add(dset_id)
+            self._make_dirty(dset_id)
 
     def deleteObject(self, obj_id):
         """ Delete the given object """
@@ -817,6 +817,7 @@ def createDataset(
             dset_json["creationProperties"] = cpl
         else:
             dset_json["creationProperties"] = {}
+        dset_json["created"] = time.time()
 
         dset_id = createObjId("datasets", root_id=self.root_id)
         self.db[dset_id] = dset_json

test/unit/hsds_writer_test.py

@@ -245,10 +245,18 @@ def testReaderWriter(self):
 
         # create a scalar dataset
         dset_id = db.createDataset(shape=(), dtype=np.int32)
+        dset_json = db.getObjectById(dset_id)
+        self.assertTrue("created" in dset_json)
+        dset_create_time = dset_json["created"]
+        self.assertTrue(dset_create_time > 0)
+
         arr = np.zeros((), dtype=np.int32)
         arr[()] = 42
         sel_all = selections.select((), ...)
         db.setDatasetValues(dset_id, sel_all, arr)
+        dset_json = db.getObjectById(dset_id)
+        self.assertTrue("lastModified" in dset_json)
+        self.assertTrue(dset_json["lastModified"] > dset_create_time)
 
         arr = db.getDatasetValues(dset_id, sel_all)
         self.assertEqual(arr[()], 42)