Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IComponentDataFields and all its subclasses seemse to be custom Java classes to be exported to Javascript, therefore should have no parameters in JsType annotation. #2

Open
yechenqiao opened this issue May 31, 2019 · 0 comments

Comments

@yechenqiao
Copy link

Please take this with a grain of salt as I'm on a newer code base Amcharts 4.4.x, while this code base is currently on 4.0.x.

I've noticed the classes extending IComponentDataFields has the wrong class annotations. These causes these classes to not be able to be used in Java at all via constructor.

Instead of @jstype(isNative = true, ...) the annotation should have just been @jstype because the class is not defined in Javascript and we are exporting the class from Java.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant