Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Favicon is calculated by the second instead of using timeouts #68

Open
ky28059 opened this issue Nov 7, 2021 · 1 comment
Open

Favicon is calculated by the second instead of using timeouts #68

ky28059 opened this issue Nov 7, 2021 · 1 comment

Comments

@ky28059
Copy link
Member

ky28059 commented Nov 7, 2021

Title. Favicon is rendered in a useEffect with dep date which updates every second. Theoretically a timeout based solution akin to the one UGWA has would save on computing power.

Also, favicon and other non-layout logic should ideally be moved out of Layout.tsx, although to where is uncertain.

@ky28059
Copy link
Member Author

ky28059 commented Jul 19, 2022

Funnily enough this issue caused quite the debugging problem when testing #106. I spent close to an hour troubleshooting why the per-page titles I had set via <Helmet> weren't displaying properly in the tab, only to eventually realize that FaviconHandler overwrote the page title every second with a preconfigured default. Maybe now is a good time to address this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant