Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape exception message in JSON Printer #119

Open
jitsedesmet opened this issue Aug 18, 2023 · 0 comments
Open

Escape exception message in JSON Printer #119

jitsedesmet opened this issue Aug 18, 2023 · 0 comments

Comments

@jitsedesmet
Copy link
Contributor

When the JSON printer needs to handle an exception, but the exception contains quotation marks, it creates an illegal JSON format. This can easily be fixed by escaping the exception message here: https://github.com/Guardsquare/proguard-core/blob/master/base/src/main/java/proguard/evaluation/util/jsonprinter/ErrorRecord.java#L47. A breaking example is the "Changing stack size" test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant