Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Popover #751

Open
4 of 5 tasks
Tracked by #367
halimahLDN opened this issue Jan 10, 2025 · 1 comment
Open
4 of 5 tasks
Tracked by #367

Popover #751

halimahLDN opened this issue Jan 10, 2025 · 1 comment
Labels
Ally An issue affecting accessibility

Comments

@halimahLDN
Copy link
Contributor

halimahLDN commented Jan 10, 2025 •
edited
Loading

  • The popover isn't keyboard accessible
    • It has an aria-expanded="true" attribute, even when not expanded
    • Custom trigger is accessible but can't be activated using VoiceOver controls (control-option-spacebar)
  • ARIA attributes must conform to valid values
    image
  • Interactive controls must not be nested
    image
@halimahLDN halimahLDN mentioned this issue Jan 10, 2025
Open
63 tasks
@jamesscottbrown jamesscottbrown added the Ally An issue affecting accessibility label Jan 14, 2025
@halimahLDN
Copy link
Contributor Author

halimahLDN commented Jan 28, 2025 •
edited
Loading

  • Popover contents aren't read by the screen reader
    • (perhaps because of the focus trap, automatically focusing the close button and thus skipping over the content?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Ally An issue affecting accessibility
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jamesscottbrown @halimahLDN