65/Setting puppetlabs/apt max version to 11.0.0 #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have tested this on Ubuntu, Debian, Alma, and Rocky and there are no issues.
bernd
requested changes
Jan 27, 2025
I have tested this on Ubuntu, Debian, Alma, and Rocky and there are no issues.
|
@bernd I have made the requested change to the metadata file, thanks for bringing that oversight to my attention. To answer your other question; in the past, for modules I owned, I would bump the major version if I changed something that could make my module stop working on a system where it currently works. That is to say, if this were my module, I would bump the major version for this change. |
|
@avitacco Thanks for the update! I agree, we should bump the major version. Thanks for your insights. |
bernd
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have tested this on Ubuntu, Debian, Alma, and Rocky and there are no issues.
This fixes #65
Notes for Reviewers