Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Social group mode (vertical/horizontal) doesn't change in editor #125

Open
viniciiusds opened this issue Sep 5, 2019 · 3 comments
Open

Comments

@viniciiusds
Copy link

viniciiusds commented Sep 5, 2019

I tested the vertical mode of the social group in my project and the demo as well and the same problem occurs when selecting the vertical mode, it doesn't change in the editor. But after converting to HTML the vertical mode works. Thanks.

Screen Shot 2019-09-05 at 17 29 16

@kickbk
Copy link

kickbk commented Sep 5, 2019

The issue is that the style attributes are hardcoded into to view with

view: {
			...coreMjmlView,
			tagName: 'table',
			attributes: {
				style: 'pointer-events: all; float: none; display: inline-table;',
			},

As you can see display: inline-table and the floar properties are set in the view, regardless of the orientation set on the Social component.

Actually the settings (Horizontal/Vertical) is passed to the Social MJML component correctly and it is, in fact, rendering horizontal and Vertical as it should, but we are just missing sending the style properties to the SocialElement component.

@artf how do we do that?

@NorthstarTech
Copy link

@artf any update on this? I also faced the same issue.

@NorthstarTech
Copy link

NorthstarTech commented Apr 20, 2020

@kickbk @viniciiusds Did you guys find the solution for this issue? @artf What's the alternate solution for this issue? Help Needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants