Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minimize() incompatible with hikari #972

Open
SergioK29 opened this issue Sep 16, 2024 · 4 comments
Open

minimize() incompatible with hikari #972

SergioK29 opened this issue Sep 16, 2024 · 4 comments
Labels

Comments

@SergioK29
Copy link

Expected and Results

minimize() shouldn't break jars using hikari

Related environent and versions

No response

Reproduction steps

HikariConfig config = new HikariConfig();
config.setDriverClassName("com.mysql.cj.jdbc.Driver");

if minimize() step is done, error:

Exception in thread "main" java.lang.RuntimeException: Failed to load driver class com.mysql.cj.jdbc.Driver in either of HikariConfig class loader or Thread context classloader
at com.zaxxer.hikari.HikariConfig.setDriverClassName(HikariConfig.java:494)
at me.test.webserver.MySQLStorageProvider.(MySQLStorageProvider.java:35)
at me.test.webserver.WebServer.main(WebServer.java:63)

Anything else?

The breakage is probably because reflection, will shadow ever plan to support reflection for minimize step?

@SergioK29 SergioK29 added the bug label Sep 16, 2024
@Goooler
Copy link
Member

Goooler commented Sep 16, 2024

Can you address a reproducer?

@SergioK29
Copy link
Author

Can you address a reproducer?

what?

@Goooler
Copy link
Member

Goooler commented Sep 16, 2024

A project to reproduce this issue.

@SergioK29
Copy link
Author

SergioK29 commented Sep 16, 2024

A project to reproduce this issue.

its just those 2 lines of code?

using library implementation("com.zaxxer:HikariCP:5.1.0")
and implementation("com.mysql:mysql-connector-j:9.0.0")
java 21
com.gradleup.shadow 8.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants