Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not suggest running task news if there's no news to share #3499

Open
djmitche opened this issue Jun 20, 2024 · 2 comments · May be fixed by #3699
Open

Do not suggest running task news if there's no news to share #3499

djmitche opened this issue Jun 20, 2024 · 2 comments · May be fixed by #3699
Assignees
@djmitche
Labels
good first issue Good for newcomers topic:news Issues related to `task news`

Comments

@djmitche
Copy link
Collaborator

Currently, if we make a release with no new news items, users will be reminded to run task news because the current version is newer than their news.version config. However, when they do so they will be told nothing is new. That's not a great UX - better to just not remind them if there are no new news items.

This will probably require moving the reminder out of CmdCustom.cpp and into CmdNews.cpp, which can calculate whether there are any news items to show. In fact, it's probably best to factor all of that out into a src/News.{h,cpp} which both CmdCustom.cpp and CmdNews.cpp refer to.
@djmitche djmitche added good first issue Good for newcomers topic:news Issues related to `task news` labels Jun 20, 2024
@djmitche djmitche moved this to Backlog in Taskwarrior Development Jun 20, 2024
@djmitche
Copy link
Collaborator Author

Split from #3196.

@djmitche djmitche mentioned this issue Jun 20, 2024
Closed
@djmitche
Copy link
Collaborator Author

If 3.1.0 doesn't have any other news to share, we should do this in 3.1.0. I think at least the task purge support will have a news item, so this is probably OK.

@djmitche djmitche moved this from Backlog to Ready in Taskwarrior Development Aug 5, 2024
@djmitche djmitche moved this from Ready to Backlog in Taskwarrior Development Oct 27, 2024
@djmitche djmitche moved this from Backlog to Ready in Taskwarrior Development Oct 27, 2024
@djmitche djmitche self-assigned this Nov 24, 2024
@djmitche djmitche moved this from Ready to In progress in Taskwarrior Development Nov 24, 2024
@djmitche djmitche linked a pull request Nov 24, 2024 that will close this issue
Open
@djmitche djmitche moved this from In progress to In review in Taskwarrior Development Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@djmitche djmitche

Labels
good first issue Good for newcomers topic:news Issues related to `task news`
Projects
Taskwarrior Development
Status: In review
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Only nag to read news when there's news to read djmitche/taskwarrior
1 participant
@djmitche