Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Allow disabling metrics and the otel-agent/otel-collector #863

Open
Shuanglu opened this issue Sep 11, 2023 · 3 comments
Open

Comments

@Shuanglu
Copy link

WHAT

I noticed that in the manifest there are some components like namespace 'config-management-monitoring'. It looks like they are only used for metrics collection. If I only want the basic feature of the config-sync like reconciling namespace/rolebinding, is it ok to remove them?

  • namespaces/config-management-monitoring
  • namespaces/config-management-system/configMap/otel-agent
  • namespaces/resource-group-system/configMap/resource-group-otel-agent
@mikebz
Copy link
Contributor

mikebz commented Oct 10, 2023

I don't think we test that scenario (there is enough permutations we are doing), but it could be that it's not needed @tiffanny29631 can chime in here.

@karlkfi
Copy link
Contributor

karlkfi commented Jan 24, 2025

The otel-agent sidecar is always installed in the config sync deployments. So if the otel-collector is not present on the cluster, those sidecars will error. And if you manually remove the sidecars, then the main app binaries would probably error and crash or log errors endlessly.

If this is a scenario you want to see, we could consider it a feature request though. FWIW, we have been considering making the metric export more easily configurable. It's possible we conceivably add an option to disable metrics completely, but it's not really something we would recommend doing in production.

Do you have a specific use case where you want to disable the metrics?

@karlkfi karlkfi changed the title Whether otel related components are required for the basic function of the "config-sync" Feature Request: Allow disabling metrics and the otel-agent/otel-collector Jan 24, 2025
@Shuanglu
Copy link
Author

The otel-agent sidecar is always installed in the config sync deployments. So if the otel-collector is not present on the cluster, those sidecars will error. And if you manually remove the sidecars, then the main app binaries would probably error and crash or log errors endlessly.

If this is a scenario you want to see, we could consider it a feature request though. FWIW, we have been considering making the metric export more easily configurable. It's possible we conceivably add an option to disable metrics completely, but it's not really something we would recommend doing in production.

Do you have a specific use case where you want to disable the metrics?

Thanks. It's just that we don't care much about the metrics itself. At least for now, the config-sync itself runs well and we don't find it's necessary for us to monitor the metrics of it. We only want it to run and sync the resources in the repo to our GKE.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants