Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(run): diagnose run/websockets CI #3828

Closed
wants to merge 24 commits into from
Closed

Conversation

subfuzion
Copy link
Member

Fixes #3827. Relates to #3822 (failing test).

Draft for now: no reviews, no merge, please.

@subfuzion subfuzion self-assigned this Sep 5, 2024
@product-auto-label product-auto-label bot added api: run Issues related to the Cloud Run API. samples Issues that are directly related to samples. asset: pattern DEE Asset tagging - Pattern. labels Sep 5, 2024
@subfuzion subfuzion closed this Sep 5, 2024
@subfuzion subfuzion reopened this Sep 5, 2024
@subfuzion subfuzion changed the title fix(run): confirm if npm install for puppeteer suffices fix(run): diagnose run/websockets CI Sep 9, 2024
@subfuzion
Copy link
Member Author

Closing PR for now (tests currently disabled with #3853, internal: b/366619034).

@subfuzion subfuzion closed this Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: run Issues related to the Cloud Run API. asset: pattern DEE Asset tagging - Pattern. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build: run/websockets tests appear to be broken by a dependency on a GCR image
1 participant