-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
testing: add workflow for functions/v2/imagemagick sample #3477
Conversation
In order for this to pass, we need two environment variables in the test runtime:
In Kokoro configuration, this looks like the following: nodejs-docs-samples/.kokoro/build.sh Line 49 in c6e0a09
nodejs-docs-samples/.kokoro/build.sh Line 70 in c6e0a09
However, I don't see an example of where the GOOGLE_CLOUD_PROJECT variable can be sourced in the GHA implementation of test runner. @pattishin could you provide guidance? |
Reassigning to @pattishin to clarify this is blocked on my end until we have preferred direction on configuring the system test behaviors. |
@grayside this feels like an area where we need to define the practice; we don't have a recommended practice and we should think through how we should do this (not just for this service) but this will then allow us to provide the guidance for other sample contributors. |
Marking this stale and closing for now. Please reopen when this is ready for review. |
Description
Fixes #3149
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
npm test
(see Testing)npm run lint
(see Style)GoogleCloudPlatform/nodejs-docs-samples
. Not a fork.