Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Make sure Compute services can use "selfLink" as External value #2730

Open
3 tasks done
yuwenma opened this issue Sep 18, 2024 · 1 comment
Open
3 tasks done
Assignees
Labels
enhancement New feature or request

Comments

@yuwenma
Copy link
Collaborator

yuwenma commented Sep 18, 2024

Checklist

  • I did not find a related open enhancement request.
  • I understand that enhancement requests filed in the GitHub repository are by default low priority.
  • If this request is time-sensitive, I have submitted a corresponding issue with GCP support.

Describe the feature or resource

This is to guarantee the backward compatibility when migrating Compute resource to the direct approach.

We need test suites that using "SelfLink" as External value for all cases under compute/v1beta1

More context: #2701 (comment)

Additional information

No response

Importance

No response

@gemmahou
Copy link
Collaborator

gemmahou commented Sep 18, 2024

Compute Forwarding Rule should not have this issue, because we are using our own resolver functions instead of the shared ones, with strict External format restriction: https://github.com/GoogleCloudPlatform/k8s-config-connector/blob/5b1307cd3451ec9fe3c252707f2a2ff32deaa3d9/pkg/controller/direct/compute/refs.go

I can add tests for forwarding rule and other resources.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants