Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate presubmit samples test failures #2621

Open
3 tasks done
gemmahou opened this issue Sep 4, 2024 · 1 comment · Fixed by #2623
Open
3 tasks done

Investigate presubmit samples test failures #2621

gemmahou opened this issue Sep 4, 2024 · 1 comment · Fixed by #2623
Labels
bug Something isn't working

Comments

@gemmahou
Copy link
Collaborator

gemmahou commented Sep 4, 2024

Checklist

Bug Description

The presubmit samples failed after PR#2583, and that blocks the open PRs.

The two failed tests are samples/regional-forwarding-rule-vpc-psc and samples/computeserviceattachment(flaky).

Checking the logs, the forwarding rule is a dependency of the service attachment, and the deletion of the forwarding rule is blocked because there is no network (the network was deleted before). It seems like we need to handle the deletion ordering in the direct controller. It's strange that the presubmit on the original PR passed. I had a temporary fix: #2614, but the two tests are still failing, so I think there's a deeper issue (deletion ordering, etc.).

Additional Diagnostic Information

job: https://github.com/GoogleCloudPlatform/k8s-config-connector/actions/runs/10681623224/job/29605684721

Kubernetes Cluster Version

N/A

Config Connector Version

N/A

Config Connector Mode

namespaced mode (default)

Log Output

No response

Steps to reproduce the issue

N/A

YAML snippets

No response

@gemmahou gemmahou added the bug Something isn't working label Sep 4, 2024
@gemmahou gemmahou reopened this Sep 4, 2024
@ziyue-101
Copy link
Collaborator

Just provide a thought.

the presubmit on the original PR passed

  • Maybe the PR has an old base and that is why it passed.
  • Could be a race condition between two controllers/reconcilers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants