-
Notifications
You must be signed in to change notification settings - Fork 217
-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to disable deadLetterPolicy on PubsubSubscription #2606
Comments
Currently remove an Object field is not fully supported by KCC:
To bypass the unsupported feature, we suggest that Cx abandon the KCC resource, leverage other tooling to disable/remove the Object type field (console, gcloud, etc.), and then acquire the resource by KCC. Detailed steps: -Update the YAML configuration of the Config Connector resource and set the cnrm.cloud.google.com/deletion-policy annotation to abandon. Ref: https://cloud.google.com/config-connector/docs/troubleshooting#abandon_and_acquire_the_resource |
Checklist
Bug Description
Disabling the deadLetterPolicy in a PubsubSubscription does not work. Removing the deadLetterPolicy parameter it from the spec makes it externally-managed instead of disabling it. The documentation describes
deadLetterPolicy
asIf dead_letter_policy is not set, dead lettering is disabled.
https://cloud.google.com/config-connector/docs/reference/resource-docs/pubsub/pubsubsubscriptionBut this is only true if its never set in the first place. Disabling after having it enabled does not work.
I have tried this guide to see if one of the suggestions would disable it: https://cloud.google.com/config-connector/docs/troubleshooting#unable_to_remove_fields_from_resource_spec
I have tried adding an empty object like
deadLetterPolicy: {}
anddeadLetterPolicy: null
, but it does not work. The system will allow it, but ignores it and the status is alwaysUpToDate
.I have also tried giving all parameter values in the deadLetterPolicy object "null" values as suggested in the troubleshooting doc, but the resource will return an error in the condition:
Additional Diagnostic Information
none
Kubernetes Cluster Version
v1.28.11-gke.1019001
Config Connector Version
1.118.2
Config Connector Mode
namespaced mode (default)
Log Output
No response
Steps to reproduce the issue
YAML snippets
The text was updated successfully, but these errors were encountered: